#16 Issue closed: disklayout.conf corrupted by dosfslabel

Labels: bug, waiting for info

dagwieers opened issue at 2012-03-22 10:48:

dosfslabel returns error output to stdout, so we cannot filter it out (this happens when eg. there are differences between boot sector and its backup). This corrupts the label= output for VFAT filesystems in this case.

dagwieers commented at 2012-03-22 10:48:

The workaround is to only consider the last line from the dosfslabel output, assuming that errors are always printed before the label is printed. An alternative solution is to depend on vol_id or blkid. Workaround implemented in 4976a19b7b05b0d3466c5a8d316181c03439fdfc

dagwieers commented at 2012-03-22 14:56:

Jeroen decided this was sufficient, I am not convinced. So make sure your FAT file system is not broken ! :-)

[Export of Github issue for rear/rear.]