#1041 PR merged: Applied corrections discussed in #1037

Labels: enhancement, fixed / solved / done

gozora opened issue at 2016-10-19 20:20:

Spelling corrections
BORG_* variables renamed to BORGBACKUP_* to avoid collisions with Borg.
When ReaR uses Borg as back end, it defaults to "none" compression to be aligned with Borg defaults.

jsmeix commented at 2016-10-20 08:37:

I have a question:
Now there is is default.conf


I assume this enforces "none" compression for rear
regardless what the users may have set in its Borg
configuration (I assume the user can configure
a compression that Borg should use), cf
where I assumed that with an empty
the Borg default gets used.

Bottom line: I wonder if


would be more in compliance with Borg?

gozora commented at 2016-10-20 08:44:

@jsmeix , exactly none compression is enforced now. I guess this is not right thing to do :-(.
BORGBACKUP_COMPRESSION="" will not however work as value is appended like this
borg create --compression <BORGBACKUP_COMPRESSION> .. so it would throw syntax error.

I'll think about some way how to solve this.

Thanks for checking!

gozora commented at 2016-10-20 08:47:

ehm, not sure if it is clear from above text, but user can change compression setting e.g. BORGBACKUP_COMPRESSION="zlib,9" in local.conf

jsmeix commented at 2016-10-20 09:20:

Of course the user can specify what he wants in local.conf
but my point and Thomas Waldmann's point in
is that when the user does not specify anything,
then rear should use Borg in its default mode.

In other words:
When the user does not specify anything in rear,
rear should not specify something special for Borg.

gozora commented at 2016-10-20 09:36:

Ok, I'll correct it.

[Export of Github issue for rear/rear.]