#2225 PR merged: Use mountpoint instead of mount|grep

Labels: enhancement, cleanup, fixed / solved / done

goldzahn opened issue at 2019-09-04 13:31:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Cleanup

  • Impact: Low

  • Reference to related issue (URL): #1390

  • How was this pull request tested? Rhel7 (rear -d -v mkrescue)

  • Brief description of the changes in this pull request: Instead of using 'mount | grep "$BUILD_DIR/outputfs"' the command 'mountpoint -q "$BUILD_DIR/outputfs"' is used.

gdha commented at 2019-09-05 11:27:

@goldzahn indeed that makes sense. If @jsmeix agrees we can merge it

goldzahn commented at 2019-09-05 13:19:

@jsmeix I followed your recommendations and changed framework-functions.sh and also 200_check_tmpfs.sh, build rpm again and tested rear -v -d mkrescue successfully , but I cannot test the duplicity part, so I cannot guarantee for that working properly.

jsmeix commented at 2019-09-11 13:29:

thank you for your contribution!

Neither can I test anything that belongs to third party backup software
because neither do I use nor do I have such software so that such code
improvements must be done without testing.
But we all looked at the plain code changes and when noone of us
noticed a possible issue with the changes, things should work.

[Export of Github issue for rear/rear.]