#2738 PR merged: Support for http sources when using PXE

Labels: enhancement, fixed / solved / done

Flunkyball opened issue at 2022-01-08 13:33:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/issues/2733

  • How was this pull request tested? yes in my own environment with 2 different virtual machines.

  • Brief description of the changes in this pull request:

Due to the performance issues involved when using TFTP for file transfer modern PXE server support HTTP(s) downloads as well.
Since it is necessary for rear to mount the upload target during creating of the rescue information HTTP targets are not supported. Hence the url specified via $PXE_TFTP_URL used for nfs, sshfs upload and TFTP download may differ from the HTTP source offered by the same PXE server.

Therefore the change introduces a new config variable $PXE_HTTP_URL to specify explicitly the HTTP download source for PXE.
If the variable is set the PXE config file will generate an additional 3rd boot option besides the unchanged standard option "rear" (via TFTP) and "local". Namely "rear-http" which includes the HTTP url information to download the kernel and initrd data.

jsmeix commented at 2022-01-11 10:44:

because I am not a PXE user I can only look at the plain code
so I would appreciate it if one of you could also have a look here
(as time permits) - ideally someone who knows about PXE

jsmeix commented at 2022-01-11 10:54:

thank you for your PXE enhancement!
It helps us so much to get a PXE enhancement by someone who actually uses it.

Now there is at least an initial HTTP support for PXE
so if your enhancement may not yet work for another PXE user
it is now much easier to further enhance what is already there.

jsmeix commented at 2022-01-11 12:50:

if there are no objections from one of you
I would like to merge it tomorrow afternoon.

[Export of Github issue for rear/rear.]