#2905 PR merged: OUTPUT=USB: Use target=i386-pc for legacy BIOS GRUB2 install on EFI systems

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2023-01-03 10:44:

not tested by me but see

  • Brief description of the changes in this pull request:

grub-install defaults to --target x86_64-efi
if the system is booted with EFI
so one cannot install a legacy-bios (or 32bit) grub
without setting the --target parameter

jsmeix commented at 2023-01-04 14:03:

when there are no objections
I would like to merge this pull request
tomorrow afternoon.

jsmeix commented at 2023-01-05 12:29:

tomorrow is public holiday in Germany (at least in Bavaria)
so I will keep it open for further review next week.

jsmeix commented at 2023-01-09 12:33:

I introduced a new USB_GRUB2_INSTALL_OPTIONS variable
to provide "final power to the user".
This is not yet documented in default.conf
so I can easily change things as needed because
I like to wait for your (@rear/contributors) feedback
whether or not it is OK as currently impemented.

This is not yet tested by me.

jsmeix commented at 2023-01-10 13:31:

I would like to merge it as is
with the new USB_GRUB2_INSTALL_OPTIONS variable
(intentionally not yet documented in default.conf)
tomorrow afternoon unless there are objections.

So users could test it and we could see
how far it works "out there" for users.

Depending on user feedback we can later
document it as is in default.conf
or do needed changes until ReaR 2.8 release
which is not earlier than summer/autumn 2023 or later
(unless critical fixes require an urgent release).

DEvil0000 commented at 2023-01-10 19:21:

looks fine to me but sadly I do not have much time at the moment for testing or patches

jsmeix commented at 2023-01-11 14:28:

@pcahyna @DEvil0000
thank you for your reviews!

[Export of Github issue for rear/rear.]