#3571 PR merged: Apply XFS options from configs in non-debug mode¶
Labels: bug, fixed / solved / done
svlv opened issue at 2026-02-21 07:55:¶
Pull Request Details:¶
-
Type: Bug Fix
-
Impact: Normal
-
Reference to related issue (URL): No issue created
-
How was this pull request tested?
Manually recovered Debian 10 with XFS -
Description of the changes in this pull request:
Currently XFS configs are not copied correctly in non-debug mode (not verbose mode) due to these quotes -"$v".
However, applying XFS options is crucial in cases when XFS was created on old software and during the recovery newer software is used. In some cases it may lead to failures during GRUB installation. GRUB checks XFS features and returns an error when encounters unknown one.
svlv commented at 2026-02-21 10:27:¶
How to reproduce in the terminal:
Wtih quotes it isn't copied:
$ unset v; touch myfile; cp "$v" myfile myfile~
cp: target 'myfile~': No such file or directory
WIthout quotes it is copied as expected:
$ unset v; touch myfile; cp $v myfile myfile~
$ file myfile~
myfile~: empty
jsmeix commented at 2026-02-23 07:54:¶
@svlv
thank you for finding this bug and for your fix!
@rear/contributors
I would like to merge it on Wednesday (25. Feb.) afternoon
unless there are objections.
jsmeix commented at 2026-02-23 07:57:¶
Fixes
https://github.com/rear/rear/commit/a8fd431fda6c47ee5d1f4e24065bc28280a1f46d
from
https://github.com/rear/rear/pull/2431
and
https://github.com/rear/rear/issues/2333
jsmeix commented at 2026-02-23 08:25:¶
I added a part to the section
https://github.com/rear/rear/wiki/Coding-Style#beware-of-the-emptiness
about
Be prepared for possibly empty command options
[Export of Github issue for rear/rear.]