#3654 Issue open: all texts in ReaR should be ASCII¶
Labels: cleanup
jsmeix opened issue at 2026-10-08 13:42:¶
According to
https://github.com/rear/rear/wiki/Coding-Style#character-encoding
all texts in ReaR should be ASCII
but we have some which are not:
# find . -type f | xargs file | grep text | grep -v 'ASCII text'
./MAINTAINERS: Unicode text, UTF-8 text
./.git/hooks/fsmonitor-watchman.sample: Perl script text executable
./README.md: Unicode text, UTF-8 text, with very long lines (640)
./.github/ISSUE_TEMPLATE/1-bug_report.yml: Unicode text, UTF-8 text
./.github/workflows/spellcheck.yml: Unicode text, UTF-8 text
./doc/user-guide/18-iSCSI.md: Unicode text, UTF-8 text
./doc/user-guide/13-tcg-opal-support.md: Unicode text, UTF-8 text, with very long lines (312)
cf.
https://github.com/rear/rear/pull/3653#discussion_r4219587069
pcahyna commented at 2026-10-08 14:01:¶
Shouldn't this rule apply only to scripts (or code in general)? I don't think that enforcing it for documentation files like MAINTAINERS brings value. Although the use of the Unicode em-dash that triggered it looks indeed quite superfluous.
jsmeix commented at 2026-10-08 14:16:¶
For scripts ASCII is mandatory.
For other files ASCII is recommended because it avoids
any character encoding issues inside the recovery system
while UFT-8 encoding normally provides no real benefit.
A file like MAINTAINERS is an exception because it is
a real benefit to have person names from all countries
written with the correct characters from their countries.
My above find output is the raw output.
I did non filter out exceptional files (like MAINTAINERS)
or false results lile "Perl script text executable".
pcahyna commented at 2026-10-08 17:05:¶
A file like MAINTAINERS is an exception because it is
a real benefit to have person names from all countries
written with the correct characters from their countries.
I agree. I thought that you wanted to change literally all occurrences shown.
[Export of Github issue for rear/rear.]