#1 PR merged: Pull fixes for partitioning and udev.¶

Labels: bug

jhoekx opened issue at 2012-02-16 12:13:¶

These fixes correspond to svn rev 765 and 766.

Tested on Arch and RHEL5.

dagwieers commented at 2012-02-16 12:33:¶

Not sure how we are organizing our workflow, but I am sure I am not going to merge pull requests of everyone :-)

jhoekx commented at 2012-02-16 12:42:¶

I think it's useful that we also restrict ourselves to "someone else should review these changes" and point out blatant errors...

That's open for discussion.

dagwieers commented at 2012-02-16 12:50:¶

I agree, but I prefer the current practice of sending changes to the list, rather than creating a pull-request (and automatic issue). Not only do you get a much larger audience, people will see the change anytime, while through Github, the first person to merge will make it invisible to the next person.

I would keep pull-requests exclusively for the occasional external contributor (and maybe for a large changeset that might be controversial), in all other cases we should be able to push to the master tree like we have been doing.

---

[Export of Github issue for rear/rear.]