#704 PR merged: Use wipefs when available to clean up disk partitions¶

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2015-11-19 13:35:¶

Use wipefs when available to clean up disk partitions
before creating filesystems there,
see https://github.com/rear/rear/issues/540
and https://github.com/rear/rear/issues/649#issuecomment-148725865

Currently "when available" means that on has to manually add it
to the rear recovery system in in /etc/rear/local.conf via
REQUIRED_PROGS=( "${REQUIRED_PROGS[@]}" wipefs )

Making wipefs automatically available to the rear recovery system
when it is available in the original system is a next step.

gdha commented at 2015-11-19 13:44:¶

@jsmeix I leave it up to you when to code is ready to pull into the upstream. Just thinking why not use a prep script to add wipefs to the REQUIRED_PROGS array, or when absent foresee a kind of alternative function (or script to be added in the skel tree)?

jsmeix commented at 2015-11-19 13:51:¶

@gdha
regardless that the curent code is not yet feature-complete
it is ready to be pulled into upstream.

I have tested the current code
on a SLES12-SP1 KVM/Qemu virtual machine
with 2.5TB virtual harddisk using SUSE's special 'gpt_sync_mbr'
and SLES12-SP1 default btrfs and xfs for /home

Both "rear --debugscripts xv mkbackup"
and "rear --debugscripts xv recover"
still "just work" for me.

I would appreciate if you pull the curent code into upstream.

gdha commented at 2015-11-19 13:55:¶

Done ;-)

jsmeix commented at 2015-11-25 12:52:¶

This particular pull request is done (i.e. "fixed")
but the whole issue https://github.com/rear/rear/issues/540
is not yet completely implemented.

---

[Export of Github issue for rear/rear.]