#709 PR merged: Copy rear recover log et alii into recovered system

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2015-11-23 10:58:

Hereby during "rear recover" the following from the recovery system

/var/log/rear/rear-<hostname>.log
/var/lib/rear/layout/*
/var/lib/rear/recovery/*

gets copied into the recovered system to a restricted directory

drwx------ /var/log/rear/recover/

plus a backward compatible symbolic link

/root/rear-<date>.log -> /var/log/rear/recover/rear-<hostname>.log

is created.

See https://github.com/rear/rear/issues/706

schlomo commented at 2015-11-23 11:13:

"rear-.log" seems a hint for a missing hostname during recovery... ?

On 23 November 2015 at 11:58, Johannes Meixner notifications@github.com
wrote:

Hereby during "rear recover" the following from the recovery system

/var/log/rear/rear-.log
/var/lib/rear/layout/*
/var/lib/rear/recovery/*

gets copied into the recovered system to a restricted directory

drwx------ /var/log/rear/recover/

plus a backward compatible symbolic link

/root/rear-.log -> /var/log/rear/recover/rear-.log

is created.

You can view, comment on, or merge this pull request online at:

https://github.com/rear/rear/pull/709
Commit Summary

  • copy rear recover log file and layout files into recovered system
  • Also copying /var/lib/rear/recovery/* from recovery system

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
https://github.com/rear/rear/pull/709.

jsmeix commented at 2015-11-23 14:11:

Actually "rear-.log" is a hint for a missing usage of '<' and '>' for '<' and '>' in comments here.

I fixed my comment.

gdha commented at 2015-11-24 17:20:

@jsmeix Personally, I would prefer to see a name like rear-$(hostname)-$WORKFLOW-<date>.log as a simple rear help could overwrite an existing log file.

jsmeix commented at 2015-11-25 08:46:

No "rear <whatever>" run overwrite files in the
separated directory /var/log/rear/recover/

Only a second "rear recover" run in the recovery system
would overwrite files in var/log/rear/recover/ in the
target system.
Currently that is intentionally because I think that the files
from a previous "rear recover" are no longer of interest
and if really needed the admin could save them manually.

But if you like I could keep the files of a previous "rear recover"
in another separated directory /var/log/rear/recover.old/
perhaps configurable via /usr/share/rear/conf/default.conf

# Keep "rear recover" log et alii of a previous "rear recover" in /var/log/rear/recover.old/
KEEP_RECOVERY_LOG=""

jsmeix commented at 2015-11-25 09:11:

Mainly to have it documented I filed https://github.com/rear/rear/issues/712 because I think there is nothing to do regarding better log file naming.

gdha commented at 2015-11-25 12:06:

@jsmeix Ok no change required after our discussion...

[Export of Github issue for rear/rear.]