#798 Issue closed: 99_sysreqs.sh: fix or implement remaining issues

Labels: enhancement, bug, cleanup, fixed / solved / done

jsmeix opened issue at 2016-03-15 14:42:

This issue is intended as follow-up of https://github.com/rear/rear/issues/795

In particular the root partition size is missing, cf.
https://github.com/rear/rear/issues/795#issuecomment-195425857

jsmeix commented at 2016-03-15 14:49:

@gdha
see my inital "FIXME" in 99_sysreqs.sh

# FIXME: Provide a leading comment what this script is about.

Can you provide me some explanatory information what
the purpose of this script is.

I see at its end that it outputs text to
$VAR_DIR/sysreqs/Minimal_System_Requirements.txt
but I have no idea what it is good for.

Is it just mean as textual information or is the content of
$VAR_DIR/sysreqs/Minimal_System_Requirements.txt
used by other scripts?

I cannot find the hardcoded file name "Minimal_System_Requirements"
nor can I find e.g. "TOTMEM" is any other script so that I wonder
what the purpose of 99_sysreqs.sh is.

gdha commented at 2016-03-15 16:11:

@jsmeix Updated the script to make more sense on all Linux distro's. If you could review the end result? The /var/lib/rear/sysreqs/Minimal_System_Requirements.txt file is not used by rear in recover mode. The purpose is to have an idea in a remote DRP center what are the minimal physical requirements of a system to foresee to perform a successful recovery from the rear image provided.

jsmeix commented at 2016-03-16 11:35:

@gdha
many thanks for your nice cleanup of 99_sysreqs.sh.

Its resulting var/lib/rear/sysreqs/Minimal_System_Requirements.txt
looks good on my system.

With your cleanup of 99_sysreqs.sh this issue here
is sufficiently fixed from my point of view.


[Export of Github issue for rear/rear.]