#891 PR `merged`: overhauled 05_start_required_daemons.sh¶

Labels: enhancement, bug, cleanup, fixed / solved / done

jsmeix opened issue at 2016-06-23 13:27:¶

use plain 'rpcinfo -p'
see https://github.com/rear/rear/issues/889

make it no longer fatal when rpc.statd is unavailable
see https://github.com/rear/rear/issues/870

removed all references to FD8
see https://github.com/rear/rear/issues/887
and https://github.com/rear/rear/pull/874

first steps to be prepared for 'set -eu'
see https://github.com/rear/rear/wiki/Coding-Style

jsmeix commented at 2016-06-23 13:31:¶

@gdha
could you please have a look
and report what you think about it.

gdha commented at 2016-06-23 14:01:¶

@jsmeix looks good to me; I just left a minor remark in your pull request - it is up to you to modify or ignore - I have no real preference.

jsmeix commented at 2016-06-23 14:11:¶

Regarding 'seq' usage in current code:

sources/rear/github/rear $ find * | xargs grep 'seq '
usr/share/rear/backup/DUPLICITY/default/50_make_duplicity_backup.sh:    # for i in $(seq 0 $(($NMBRS - 1)) )
usr/share/rear/lib/layout-functions.sh:  for pos in $(seq 0 $(( max -1 ))); do
usr/share/rear/lib/network-functions.sh:                        for j in $(seq $pads); do
usr/share/rear/lib/network-functions.sh:            for i in $(seq 5); do
usr/share/rear/lib/udev-workflow.sh:                for i in $(seq 1 15); do
usr/share/rear/output/ISO/Linux-i386/81_prepare_multiple_iso.sh:for i in `seq -f '%02g' 1 $(($NB_ISOS-1))`; do
usr/share/rear/verify/NETFS/default/05_start_required_daemons.sh:for attempt in $( seq 5 ) ; do

I think I better make 'seq' one of the REQUIRED_PROGS.

jsmeix commented at 2016-06-23 14:13:¶

First test result:
Works well for me on SLES11-SP4:

RESCUE g130:~ # rear -d -D recover
Relax-and-Recover 1.18 / Git
Using log file: /var/log/rear/rear-g130.log
Starting required daemons for NFS: RPC portmapper (portmap or rpcbind) and rpc.statd if available.
Started RPC portmapper 'rpcbind'.
RPC portmapper 'rpcbind' available.
Started rpc.statd.
RPC status rpc.statd available.
NOTICE: Will do driver migration
...

jsmeix commented at 2016-06-23 14:18:¶

Second test result:
Works well for me on SLES12-SP1:

RESCUE f121:~ # rear -d -D recover
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_GB.iso885915)
Relax-and-Recover 1.18 / Git
Using log file: /var/log/rear/rear-f121.log
Starting required daemons for NFS: RPC portmapper (portmap or rpcbind) and rpc.statd if available.
Started RPC portmapper 'rpcbind'.
RPC portmapper 'rpcbind' available.
Started rpc.statd.
RPC status rpc.statd available.
NOTICE: Will do driver migration
...

jsmeix commented at 2016-06-23 14:28:¶

Hmmm...
the PROGS array in usr/share/rear/conf/GNU/Linux.conf
lists so many basic tools and there is no
REQUIRED_PROGS array in usr/share/rear/conf/GNU/Linux.conf
that I think the PROGS versus REQUIRED_PROGS issue
for basic tools should be handled in a separated issue:
https://github.com/rear/rear/issues/892

jsmeix commented at 2016-06-23 14:32:¶

I merge it because it works well for me and
so that others can test it via rear GitHub master.

jsmeix commented at 2016-06-27 09:32:¶

For completeness:

With
https://github.com/rear/rear/commit/276bf61666f25416f27e76a3ad8753e18d674142

usr/share/rear/verify/NETFS/default/05_start_required_daemons.sh
was renamed into
usr/share/rear/verify/NETFS/default/05_start_required_nfs_daemons.sh

[Export of Github issue for rear/rear.]

#891 PR merged: overhauled 05_start_required_daemons.sh¶