#997 PR closed: Adding a missing default directory and introducing a parameter¶

Labels: enhancement, cleanup, fixed / solved / done

dl5rcw opened issue at 2016-09-15 17:58:¶

I am running rear + bareos in our environment. Each client has its own fileset, thus needed a specific restore job. I noticed that I need to add a parameter to tell rear which restore job to automatically start.

I also noticed that a default folder was missing. I added this folder and rear + bareos work fine since quite a few months. It seems to be time to share this and offer this contribution.

jsmeix commented at 2016-09-16 07:53:¶

I cannot really check anything semantically here because
I never used Bareos but I can do some superficial
mainly syntactical check:

You use a variable named BAREOS_RESTOREJOB
that I cannot find anywhere in the current rear code
but I can find a variable named BAREOS_RESTORE_JOB in
usr/share/rear/prep/BAREOS/default/55_check_bareos_restore_jobs.sh

I guess what is actually needed is an enhancement of
how BAREOS_RESTORE_JOB currently works.

In particular that BAREOS_RESTORE_JOB is documented
in usr/share/rear/conf/default.conf therein in
the "# BACKUP=BAREOS stuff (bareos.org)" section.
and that its usage is sufficiently explained there.

@gdha
because (according to "git blame")
usr/share/rear/prep/BAREOS/default/55_check_bareos_restore_jobs.sh
was made by you I assign this pull request also to you.

jsmeix commented at 2016-09-28 13:02:¶

The curent rear master code contains in
restore/BAREOS/default/40_restore_backup.sh

            FILESET="fileset=\"$BAREOS_FILESET\""
        fi
        if [ -n "$BAREOS_RESTORE_JOB" ]
        then
            RESTOREJOB="restorejob=$BAREOS_RESTORE_JOB"
        fi
        echo "restore client=$BAREOS_CLIENT $RESTOREJOB $FILESET where=$TARGET_FS_ROOT select all done
" |     bconsole

which is the same code as in your pull request
except that BAREOS_RESTORE_JOB is used
(and not BAREOS_RESTOREJOB).

Therefore I think it is already fixed in curent rear master code
and accordingly I close this pull request as (already) "fixed".

---

[Export of Github issue for rear/rear.]