#1016 PR closed: Update 40_restore_backup.sh

Labels: enhancement, won't fix / can't fix / obsolete

philippebolduc opened issue at 2016-09-28 14:32:

tar --test-label is not supported on Centos 5 who have tar version 1.15

jsmeix commented at 2016-09-28 15:02:

@gdha
it definitely needs further improvement because
now the if condition has become useless
because now the actual code is:

if is_true "$BACKUP_PROG_CRYPT_ENABLED" ; then
    BASE=$BASEDIR/$(cat $BASEDIR/basebackup.txt)
else
    BASE=$BASEDIR/$(cat $BASEDIR/basebackup.txt)
fi

philippebolduc commented at 2016-09-28 15:09:

Yes you're right.

Philippe Bolduc
Administrateur système Linux / Programmeur analyste
Linux System Administrator / Programmer Analyst

http://www.florenceinc.com/
3382, boul. Industriel
Laval (Québec)
H7L 4R9
T :: 514-875-7525 #235
F :: 514-875-7536
C :: philippe@florenceinc.com
W :: florenceinc.com
Le 2016-09-28 à 11:03, Johannes Meixner a écrit :

@gdha https://github.com/gdha
it definitely needs further improvement because
now the if condition has become useless
because now the actual code is:

if is_true "$BACKUP_PROG_CRYPT_ENABLED" ; then
BASE=$BASEDIR/$(cat $BASEDIR/basebackup.txt)
else
BASE=$BASEDIR/$(cat $BASEDIR/basebackup.txt)
fi

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rear/rear/pull/1016#issuecomment-250193840, or
mute the thread
https://github.com/notifications/unsubscribe-auth/AJuhY9KpIbX0o9iae4F7BeP2OdxJtO6Nks5quoGmgaJpZM4KI5c9.

jsmeix commented at 2016-09-29 13:55:

According to
https://github.com/rear/rear/issues/1014#issuecomment-250471724
we will not do the work to make the new
"BACKUP_TYPE=incremental" functionality
working with old tar < 1.15.92
so that I close this currently incomplete
pull request.

@philippebolduc
nevertheless many thanks for your valuable contribution
to Relax-and-Recover because now we learned under
what special circumstances tar < 1.15.92 fails and you
even provided a "quick and dirty" workaround that could
also be used by other users who have that issue.

[Export of Github issue for rear/rear.]