#1023 Issue `closed`: Notification feature to rear¶

Labels: enhancement, fixed / solved / done

phracek opened issue at 2016-10-04 08:40:¶

Relax-and-Recover (rear) Issue Template¶

Please fill in the following items before submitting a new issue:

rear version (/usr/sbin/rear -V): 1.17.2
OS version (cat /etc/rear/os.conf or lsb_release -a): RHEL-6.8
rear configuration files (cat /etc/rear/site.conf or cat /etc/rear/local.conf):
Brief description of the issue
Once backup is completed (rear mkbackup), customer would like to log message that "backup complete" with a timestamp and location of the backup so the result can be inserted into a database.
Work-around, if any

Pull Request #1022

Reference rhbz: https://bugzilla.redhat.com/show_bug.cgi?id=1377547

jsmeix commented at 2016-10-04 09:00:¶

https://bugzilla.redhat.com/show_bug.cgi?id=1377547
tells me

You are not authorized to access bug #1377547.
To see this bug, you must first log in to an account
with the appropriate permissions.

jsmeix commented at 2016-10-04 09:04:¶

FWIW:
In general I think (as far as I remember) rear runs silent
(except in verbose mode) like traditional Unix programs
"no news is good news".

Personally I prefer verbosity but that is my personal
preference (and not what rear does by default - as
far as I remember).

@gdha @schlomo
can you comment what the default rear behaviour
should be regarding verbosity?

gdha commented at 2016-10-04 11:19:¶

@phracek rear exits with recording an exit status in the journal/messages file - is that not enough?

jsmeix commented at 2016-10-04 12:05:¶

@phracek
at least I need much better background information
what the intent behind is to understand the issue.

The curent implementation in
https://github.com/rear/rear/pull/1022/files
is a hack that perhaps works for this one customer
(but I don't know what his intent behind is)
but in general it is wrong because

a)
it does the

LogPrint "Finished running $WORKFLOW workflow $BACKUP_URL `date` "

for any workflow (in particular also for "rear mkrescue")
where no backup is made

b)
we would get a somewhat duplicate messaging

Log "Finished running $WORKFLOW workflow"
LogPrint "Finished running $WORKFLOW workflow $BACKUP_URL `date` "

with "Finished running $WORKFLOW workflow" two times.

Summary:

From my point of view in its current state
both the issue and its implementation
look rather crude.

@phracek
in general have a look at
https://github.com/rear/rear/wiki/Developers-Guide

jsmeix commented at 2016-10-04 12:06:¶

Typo correction - I meant:
in general have a look at
https://github.com/rear/rear/wiki/Coding-Style

jsmeix commented at 2016-10-04 12:27:¶

This issue is not for the 1.19 release (=> "Rear future").

For a future release (hopefully for 1.20) I will try to clean up
messaging in general, cf. https://github.com/rear/rear/issues/885
and https://github.com/rear/rear/issues/887

jsmeix commented at 2016-10-21 08:29:¶

According to
https://github.com/rear/rear/pull/1022#issuecomment-255162154
and
https://github.com/rear/rear/pull/1022#issuecomment-255323450
this issue is fixed
in rear 1.19 via POST_BACKUP_SCRIPT, cf.
https://github.com/rear/rear/pull/977

[Export of Github issue for rear/rear.]

#1023 Issue closed: Notification feature to rear¶