#1055 PR `merged`: Correction in behavior of Borg environment variables¶

Labels: enhancement, cleanup, fixed / solved / done, minor bug

gozora opened issue at 2016-10-27 17:53:¶

Applied changes discussed in #1052.

jsmeix commented at 2016-10-28 07:51:¶

@gozora
if this pull request is finished from your point of view
I woulkd just merge it.

gozora commented at 2016-10-28 07:58:¶

@jsmeix Yes, it is.

jsmeix commented at 2016-10-28 09:09:¶

I found a typo in a comment in default.conf:

# into ReaRs local.conf/site.conf.

(i.e. the plural ...s is used here).
It should be

# into ReaR's local.conf/site.conf.

(i.e. the genitive ...'s is actually meant)

No need to do a pull request only because of this.
Perhaps you can include it in a future pull request.

gozora commented at 2016-10-28 09:10:¶

@jsmeix I'll correct it, just give me a minute ;-)

gozora commented at 2016-10-28 09:15:¶

ah you've merged it already ...
So fine, I'll note it somewhere ...

jsmeix commented at 2016-10-28 09:18:¶

I found another minor issue in default.conf:

On my system I get:

$ less usr/share/rear/conf/default.conf
...
# When set, use the given path/filename as remote path (default is â200234borgâ200235)
...
$ file usr/share/rear/conf/default.conf
usr/share/rear/conf/default.conf: UTF-8 Unicode English text

You use UTF-8 characters.
Please use only simple traditional (7-bit) ASCII charactes, cf.
https://github.com/rear/rear/issues/1018#issuecomment-251385721

jsmeix commented at 2016-10-28 09:45:¶

I added a section "Character Encoding" to
https://github.com/rear/rear/wiki/Coding-Style

gozora commented at 2016-10-28 09:48:¶

That was an accident. Since my grammar fiasco. I use Libreoffice for spellchecks ...

jsmeix commented at 2016-10-28 10:01:¶

Ahhh!
You trust robots (LibreOffice) more than yourself ;-))

gozora commented at 2016-10-28 10:19:¶

Of course I do! :-)

gozora commented at 2016-10-28 11:02:¶

apt-get install geany-plugin-spellcheck (hopefully) did the trick. Now I can look smart and use right encoding as well :-)

jsmeix commented at 2016-10-28 11:55:¶

Right now I remember that I can simply fix such minor typos
directly via the GitHub web frontend which I did hereby:
https://github.com/rear/rear/commit/6ccbab0839d25b8d7291741f380b308970371999

gozora commented at 2016-10-28 12:07:¶

Thanks!

[Export of Github issue for rear/rear.]

#1055 PR merged: Correction in behavior of Borg environment variables¶