#1098 Issue closed: Some workflows do not work with '-s' (validate, shell, and format)

Labels: fixed / solved / done, minor bug

jsmeix opened issue at 2016-12-02 09:52:

The workflows 'validate' and 'shell' do not work correctly
when rear is called with the '-s' option

# find usr/share/rear/ | grep -- '-workflow.sh'
usr/share/rear/lib/format-workflow.sh
usr/share/rear/lib/checklayout-workflow.sh
usr/share/rear/lib/recover-workflow.sh
usr/share/rear/lib/validate-workflow.sh
usr/share/rear/lib/dump-workflow.sh
usr/share/rear/lib/shell-workflow.sh
usr/share/rear/lib/udev-workflow.sh
usr/share/rear/lib/finalizeonly-workflow.sh
usr/share/rear/lib/mkrescue-workflow.sh
usr/share/rear/lib/restoreonly-workflow.sh
usr/share/rear/lib/layoutonly-workflow.sh
usr/share/rear/lib/mkbackuponly-workflow.sh
usr/share/rear/lib/help-workflow.sh
usr/share/rear/lib/mkbackup-workflow.sh
usr/share/rear/lib/savelayout-workflow.sh

# for w in format checklayout recover validate \
 dump shell udev finalizeonly mkrescue restoreonly \
 layoutonly mkbackuponly help mkbackup savelayout ; \
 do echo $w ; usr/sbin/rear -s $w ; done

hangs up for 'validate' and 'shell'.

jsmeix commented at 2016-12-14 12:30:

Fixed via
https://github.com/rear/rear/pull/1127

jsmeix commented at 2016-12-23 10:59:

Also the format workflow does not work with plain '-s':

f79:~/rear # usr/sbin/rear -s format
Relax-and-Recover 1.19 / Git
Using log file: /root/rear/var/log/rear/rear-f79.log
Simulation mode activated, Relax-and-Recover base directory: /root/rear/usr/share/rear
Source conf/Linux-i386.conf
Source conf/GNU/Linux.conf
822: Source init/default/010_set_drlm_env.sh
822: Source init/default/030_update_recovery_system.sh
822: Source init/default/050_check_rear-recover_mode.sh
822: ERROR: No device provided as argument.
Aborting due to an error, check /root/rear/var/log/rear/rear-f79.log for details
822: You should also rm -Rf /tmp/rear.TXxhoWATfzryZVu
Terminated

It works with a device "usr/sbin/rear -s format /dev/sdb"
but in simulation mode it should work witout any further
command line parameters.

jsmeix commented at 2016-12-23 12:16:

With https://github.com/rear/rear/pull/1140 merged
simulation mode for the format workflow works now
even without a device specified.

[Export of Github issue for rear/rear.]