#1176 PR `closed`: Warn if initrd cannot be created when udev not there¶

Labels: enhancement, cleanup, fixed / solved / done

jsmeix opened issue at 2017-01-23 13:33:¶

Warn if initrd cannot be created when udev not there
and some more code cleanup, see
https://github.com/rear/rear/pull/1171#issuecomment-274442700

jsmeix commented at 2017-01-23 13:35:¶

@gdha
currently this one is not at all tested by me.
I will test it tomorrow.
I only did that pull request soon so that
you could have a first look if you like.

gdha commented at 2017-01-23 16:27:¶

@jsmeix Wait for the merging pull request 'till you have tested it yourself first.

jsmeix commented at 2017-01-24 12:04:¶

FYI regarding my code cleanup:
I documented the basic idea behind in the new section
"Return early, return often" in
https://github.com/rear/rear/wiki/Coding-Style

jsmeix commented at 2017-01-24 15:21:¶

Does not yet work because
'cmp' is missing in the recovery system:

+ source /usr/share/rear/finalize/SUSE_LINUX/i386/170_rebuild_initramfs.sh
++ test -s /tmp/rear.ZrH4yz5LjAGGsMC/tmp/storage_drivers
++ cmp -s /tmp/rear.ZrH4yz5LjAGGsMC/tmp/storage_drivers /var/lib/rear/recovery/storage_drivers
/usr/share/rear/finalize/SUSE_LINUX/i386/170_rebuild_initramfs.sh: line 11: cmp: command not found

jsmeix commented at 2017-01-25 14:20:¶

Damn!
Now I have messed up this pull request.

jsmeix commented at 2017-01-25 15:10:¶

I did a new (and hopefully clean) pull request:
https://github.com/rear/rear/pull/1179

[Export of Github issue for rear/rear.]

#1176 PR closed: Warn if initrd cannot be created when udev not there¶