#1217 PR merged: mkrescue partition alignment enhancement¶
Labels: enhancement, fixed / solved / done
ProBackup-nl opened issue at 2017-03-05 21:58:¶
including rounding user UEFI size input to alignment values and enhancing with an option to insert parameters in the mkrescue mkfs.(ext3|ext4) phase for improved speed and lifetime of USB flash memory media; issue #1201
jsmeix commented at 2017-03-06 09:50:¶
@ProBackup-nl
many thanks for your contribution!
In general I agree with what you did.
I have two issues left:
Please also document the new "lz4 default -1 compression"
in usr/share/rear/conf/default.conf at the place where
REAR_INITRD_COMPRESSION is described e.g. like
# With REAR_INITRD_COMPRESSION="lz4" # an initrd.lz4 with lz4 default -1 compression is created (fast speed but less compression).
I do not understand the meaning of the following test in
usr/share/rear/format/USB/default/300_format_usb_disk.sh
test "$USB_PARTITION_ALIGN_BLOCK_SIZE" -eq "$USB_PARTITION_ALIGN_BLOCK_SIZE" || ...
because I think it always evaluates to 'true'
so that the code after the '||' will never be run.
ProBackup-nl commented at 2017-03-06 10:22:¶
@jsmeix The
test "$USB_PARTITION_ALIGN_BLOCK_SIZE" -eq "$USB_PARTITION_ALIGN_BLOCK_SIZE"
should not equate to true when $USB_PARTITION_ALIGN_BLOCK_SIZE
contains a floating point and not an integer.
This check is the test for "is $USB_PARTITION_ALIGN_BLOCK_SIZE an integer value?", in case it is not, fall back to the default value (of 8).
# test "1.5" -eq "1.5" || echo "Not equal"
-bash: test: 1.5: integer expression expected
Not equal
Hmm, hould I add some piping to hide/redirect the error, or should I better keep the message?
[Export of Github issue for rear/rear.]