#1236 PR merged
: doc lz4 -1 changed to lz4 -l¶
Labels: enhancement
, documentation
, fixed / solved / done
ProBackup-nl opened issue at 2017-03-11 11:51:¶
lz4 -l is necessary for Linux kernel boot compatibility, a separate branch and patch has already been pull request for that change in code. This patch also updates the documentation for that change. And it includes a table with an example to show the real life trade offs for extraction time, creation time and size based on an example.
jsmeix commented at 2017-03-13 09:44:¶
I will merge this one when I merge
https://github.com/rear/rear/pull/1235
gdha commented at 2017-03-13 11:08:¶
@jsmeix @ProBackup-nl Perhaps wait a few days to merge this pull request as it was already added some days ago. I want to be sure it is a valid one.
jsmeix commented at 2017-03-13 11:17:¶
@gdha
the actual change is in
https://github.com/rear/rear/pull/1235
and I think this cannot go wrong because
the lz4 initrd compression was newly added
by @ProBackup-nl and when he now changes it
there cannot be regressions.
ProBackup-nl commented at 2017-03-14 01:48:¶
@gdha The was insufficient testing in my initial commit. I only tested writing. I skipped the part to test that I could actually boot from is. Any suggestions what else I could/should test?
jsmeix commented at 2017-03-14 08:37:¶
According to
https://github.com/rear/rear/pull/1236#issuecomment-286077835
I will wait until Thursday and merge this one together with
https://github.com/rear/rear/pull/1235
on Thursday if there are no objections from @gdha
jsmeix commented at 2017-03-14 08:40:¶
For some background information see
https://github.com/rear/rear/issues/1218#issuecomment-285817529
[Export of Github issue for rear/rear.]