#1252 PR merged
: DRLM management and security improvements¶
Labels: enhancement
, documentation
, cleanup
,
fixed / solved / done
, external tool
didacog opened issue at 2017-03-17 16:39:¶
This PR will improve DRLM and ReaR integration and solve a DRLM issue opened by @gdha (https://bugzilla.redhat.com/show_bug.cgi?id=1239003).
brief description of changes:
- add support for Multiple configs
rear -C confname
in DRLM (issue #1229) - Solve issue https://github.com/brainupdaters/drlm/issues/42, now the connection is verified by default and properly documented in default.conf.
- Now ReaR logs will be sent in real time to DRLM.
- Improved error handling with DRLM RESTful API and keep backwards compatibility with previous versions of ReaR (since 1.17) on DRLM side.
- New default REAR_CAPATH="/etc/rear/cert" to store SSL certs used by ReaR. see default.conf
This code has been tested on RHEL/CentOS, SLES/OpenSUSE and Debian/Ubuntu.
jsmeix commented at 2017-03-21 10:19:¶
@didacog
onyl a side note FYI:
I think the drlm_is_managed function can nowadays be
replaced by ReaR's generic function is_true
see lib/global-functions.sh for its usage.
Beware!
is_true is not the logical inverse of is_false, cf.
https://github.com/rear/rear/pull/1212#issuecomment-283698753
Therefore
if ! drlm_is_managed ; then return 0 fi
would have to be replaced by
if ! is_true "$DRLM_MANAGED" ; then return 0 fi
or shorter by
is_true "$DRLM_MANAGED" || return 0
but the following would go wrong:
is_false "$DRLM_MANAGED" && return 0
didacog commented at 2017-03-21 10:23:¶
@jsmeix Ok, I can change this and update de PR if you want or send a new PR for this change.
jsmeix commented at 2017-03-21 11:11:¶
@didacog
if it is o.k. for you I would prefer when you change this PR.
didacog commented at 2017-03-22 16:16:¶
@jsmeix
I've changed replaced drlm_is_managed by is_true.
Also improved a little the explanation of REAR_CAPATH in default.conf
Regards,
[Export of Github issue for rear/rear.]