efi match in 320_include_uefi_env¶

Labels: enhancement, cleanup, won't fix / can't fix / obsolete

ProBackup-nl opened issue at 2017-04-13 19:55:¶

(2) Also trying to fix:

FIXME: I jsmeix@suse.de wonder if ReaR should also decide via the code below
if the variable USING_UEFI_BOOTLOADER has already an explicit 'true' value set.
I think if the variable USING_UEFI_BOOTLOADER has an explicit 'true' value set
but the code below returns before "it is safe to turn on USING_UEFI_BOOTLOADER=1"
then something is probably wrong because the user wants USING_UEFI_BOOTLOADER
but the tests in the code below seem to contradict what the user wants
so that probably ReaR should better abort here with an error and not
blindly proceed and then fail later in arbitrary unpredictable ways
cf. https://github.com/rear/rear/issues/801#issuecomment-200353337
or is it also usually "safe to proceed with USING_UEFI_BOOTLOADER=1"
when the user has explicitly specified that regardless of the tests below?

(3) Inserting FIXME for the potential redundant /boot/[eE][fF][iI] check.

jsmeix commented at 2017-04-18 11:00:¶

@gdha
can you have a look at the code below

# next step, is case-sensitive checking /boot for case-insensitive /efi directory (we need it)
# FIXME: I <2010@probackup.nl> wonder whether it is necessary to have this check here because
# an identical check is already there in 310_include_uefi_tools.sh 
# and the next step "check filesystem partition type (vfat?)" has near identical logic.

because according to
"git log -p --follow usr/share/rear/prep/default/320_include_uefi_env.sh"
that test was initially from you.

gdha commented at 2017-04-18 15:28:¶

@jsmeix @ProBackup-nl @gozora usr/share/rear/prep/default/320_include_uefi_env.sh needs a serious facelift - will have a look at it during this week if time permits

gozora commented at 2017-09-12 09:09:¶

This PR is superseded by https://github.com/rear/rear/pull/1481, hence can be closed.
Any objections?

V.

jsmeix commented at 2017-09-13 10:12:¶

Superseded by https://github.com/rear/rear/pull/1481

[Export of Github issue for rear/rear.]