#1383 PR merged: Allow backup to be stored in ISO for ppc64/ppc64le

Labels: enhancement, cleanup, fixed / solved / done

schabrolles opened issue at 2017-06-12 17:22:

As said in #697(comment), syslinux package (which provide isolinux) is only available for x86 arch.

I proposed to adapt x86 scripts for POWER (ppc64/ppc64le)

  1. usr/share/rear/output/ISO/Linux-ppc64le/800_create_isofs.sh
    removing creation of iso (will be done by new script 820_create_image_iso.sh)

  2. usr/share/rear/output/ISO/Linux-ppc64le/810_prepare_multiple_iso.sh
    (New script) create multiple iso when needed. it can be linked to Linux-i386/810_prepare_multiple_iso.sh (no ppc64 specific)

  3. usr/share/rear/output/ISO/Linux-ppc64le/820_prepare_multiple_iso.sh
    (New script) create iso file. need to use a "specific" ppc64le script as there is no isolinuxon ppc64le

Note: ppc64 scripts are the same as ppc64le (can be linked)

This pull request help to answer to #697 #1375

jsmeix commented at 2017-06-19 10:37:

@schabrolles
currently the automated Travis test fails with

./usr/share/rear/output/ISO/Linux-ppc64/800_create_isofs.sh: No such file or directory

I think this is because a symlink does not use a relative path.

I think it is the symlink

usr/share/rear/output/ISO/Linux-ppc64/800_create_isofs.sh

that seems to point to

usr/share/rear/output/ISO/Linux-ppc64le/800_create_isofs.sh

but I think it should actually point to

../Linux-ppc64le/800_create_isofs.sh

jsmeix commented at 2017-06-19 11:39:

@schabrolles
when you are working on that scripts
could you also replace all

>&8

with

>&2

cf. https://github.com/rear/rear/pull/874#issuecomment-227135652
and https://github.com/rear/rear/pull/1365
plus https://github.com/rear/rear/pull/1359#discussion_r116239195
and the new "What to do with stdout and stderr" in
https://github.com/rear/rear/wiki/Coding-Style

jsmeix commented at 2017-06-20 08:00:

@schabrolles
please tell when we can merge it.
Currently there is no 810_prepare_multiple_iso.sh
but I think - at least for now - only documentation
about the limitations is sufficient, cf.
https://github.com/rear/rear/issues/697#issuecomment-309406317

jsmeix commented at 2017-06-20 08:02:

Oops - I overlooked the
usr/share/rear/output/ISO/Linux-ppc64le/810_prepare_multiple_iso.sh
link that point to ../Linux-i386/810_prepare_multiple_iso.sh

@schabrolles
does this mean even multiple ISOs work on POWER now?

schabrolles commented at 2017-06-20 08:20:

@jsmeix
Yes, it works with multiple ISO on POWER..... as x86 (tested with RHEL7)
and you are right, I used the x86 version of 810_prepare_multiple_iso.sh as we don't need a ppc64/ppc64le specific script for that.

jsmeix commented at 2017-06-20 12:10:

@schabrolles
wow!

I will "just merge" it.

[Export of Github issue for rear/rear.]