#1422 PR merged: Improve #1415 to also explain where the USB device is mounted

Labels: enhancement, fixed / solved / done

schlomo opened issue at 2017-07-17 18:47:

@gozora can you please check if this would work? I think it will help the users if we explain them why ReaR aborts and to give them a chance to fix it.

gozora commented at 2017-07-17 18:55:

@schlomo
Yes I think that might be useful information.

V.

schlomo commented at 2017-07-17 18:57:

@gozora please check & improve as you see fit and merge. I can't test it here and fully trust you. I simply thought that it is probably easier to just send you a PR with my thoughts in code than to describe them in text.

gozora commented at 2017-07-17 19:00:

@schlomo I'll take a look on this, once I have that retry_command () story done ;-)

V.

schlomo commented at 2017-07-17 19:09:

@gozora here you go, only show the mount point :-)

jsmeix commented at 2017-07-18 08:24:

And here I even see that I am 12 hours behind @gozora

Explanation:
I had looked directly at
https://github.com/rear/rear/commit/e7dcb4e5546bb1d0422cb2703d2ee1c0e7571c34

jsmeix commented at 2017-07-18 08:31:

@schlomo
yes, it a good training exercise for users
wo don't see after the ReaR error message
all their other mountpoints where it is also mounted
to exercise the iterative step-by-step approach ;-)

jsmeix commented at 2017-07-25 10:23:

Now what I see under the "Files changed" tab of this pull request
it looks unexpected/strange to me because now it looks as if
this pull request contains several additionally changed files
that are not meant to be changed by this pull request.
Is this only a strange way what GitHub shows
or did this pull request get somehow broken?

schlomo commented at 2017-07-25 11:18:

Good catch, I think I need to push this again, will do so in the evening. This branch is definitively broken.

jsmeix commented at 2017-07-25 13:02:

Some time ago such unexpected additionally changed files
happened also to me in one of my pull requests but I cannot
remember the reason. I think I vaguely remember it might
have been something like "git rebase" in my branch or so.

schlomo commented at 2017-07-25 19:14:

@jsmeix @gozora I fixed the branch by force pushing the correct commits into it. Please update your copy to try it out. Thanks a lot.

gozora commented at 2017-07-26 19:28:

@schlomo I just finished testing. It looks OK for me.

V.

[Export of Github issue for rear/rear.]