#1471 PR merged: Overhauled 900_clone_users_and_groups.sh¶
Labels: enhancement, cleanup, fixed / solved / done
jsmeix opened issue at 2017-09-04 15:40:¶
Now rescue/default/900_clone_users_and_groups.sh
should match
https://github.com/rear/rear/wiki/Coding-Style
plus some possible bug fixes (more fail safe - hopefully)
and a better description in default.conf
jsmeix commented at 2017-09-04 15:40:¶
Please wait - it is not yet tested...
jsmeix commented at 2017-09-04 15:46:¶
@N3WWN
have a look if you think it is also o.k. this way
for your
https://github.com/rear/rear/pull/1464
(I cannot add you as an official reviewer here).
jsmeix commented at 2017-09-05 09:34:¶
I tested it and it seems to work at least for me.
jsmeix commented at 2017-09-05 10:27:¶
If there are no furious objections ;-)
I like to merge it soon...
jsmeix commented at 2017-09-05 11:33:¶
@schlomo
whoops!
I clicked in my browser "reload page"
but it did not show your comments
so that I have merged it now "as is".
jsmeix commented at 2017-09-05 11:35:¶
That CLONE_ALL_USERS_GROUPS
replaces the CLONE_USERS and CLONE_GROUPS
is what was and still is documented in default.conf
and what was and still is implemented.
My changes should not change the behaviour
compared to wat it was directly before my changes.
jsmeix commented at 2017-09-05 11:55:¶
It continues with
https://github.com/rear/rear/pull/1472
but only minor adaptions there - no change in behaviour.
Because it still works as it worked before
https://github.com/rear/rear/pull/1471
(at least according to what I see)
I close this one as "fixed".
Of course if I implemented new bugs
with my pull requests, then I will fix them.
N3WWN commented at 2017-09-05 19:07:¶
@N3WWN
have a look if you think it is also o.k. this way
for your #1464
(I cannot add you as an official reviewer here).
Yup, looks good to me, @jsmeix ! The changes that I suggested for issues I ran into when work on the YUM backup method are taken into account, so I'm happy.
[Export of Github issue for rear/rear.]