#1474 Issue closed: Clean up vagrant and virtualbox detection¶
Labels: enhancement, cleanup, no-issue-activity
schlomo opened issue at 2017-09-06 13:59:¶
Currently vagrant and VirtualBox support is detected in usr/share/rear/rescue/default/550_vagrant.sh.
TODO
- [x] split into two scripts, one for vagrant and one for VirtualBox
- [ ] use
getentto access the passwd, group and shadow databases - [ ] don't assume that the password is hashed with MD5, if there is no password in the source system then there doesn't need to be one in the rescue system
- [ ] don't assume that admin is a relevant group (I actually doubt that this works since we don't include sudo)
- [ ] add support for more recent VBoxService implementations that use systemd or upstart
jsmeix commented at 2017-09-07 10:37:¶
Because @gdha is the only author of
usr/share/rear/rescue/default/550_vagrant.sh
as far as
"git log -p --follow usr/share/rear/rescue/default/550_vagrant.sh"
tells, I dare to assign this issue to him - at least initially.
gdha commented at 2017-09-20 10:17:¶
Some background information about the origin of the script #486 and https://gist.github.com/Reiner030/4b602289320f3c2ed4e7
gdha commented at 2017-09-25 11:41:¶
As @schlomo has started to split up the script in two pieces I prefer that Schlomo also owns the issue as well. Honours to the one who works on it ;-)
schlomo commented at 2017-09-25 11:44:¶
Haha, I forgot this one and just thought again "why does virtualbox depend on vagrant?". Can't promise to do all of that, though.
gdha commented at 2017-10-31 09:46:¶
@schlomo On Ubuntu16.04 we run into trouble with
/opt/VBoxGuestAdditions-5.1.26 inclusion:
See
https://github.com/gdha/rear-automated-testing/issues/35
for the error report.
I wonder if we really need all of this?
VBOX_COPY_AS_IS=( /etc/init.d/vboxadd* /opt/VBoxGuestAdditions-* /usr/sbin/VBoxService )
from script prep/GNU/Linux/280_include_virtualbox.sh
github-actions commented at 2020-07-01 01:33:¶
Stale issue message
[Export of Github issue for rear/rear.]