#1481 PR merged: Fix UEFI tools integration (should address issues in #1477, #1478)¶

Labels: enhancement, bug, cleanup, fixed / solved / done

OliverO2 opened issue at 2017-09-11 14:26:¶

This change integrates UEFI tools on demand as determined by 320_include_uefi_env.sh.

It avoids replicating UEFI tests already done in 320_include_uefi_env.sh and just relies on a correctly set $USING_UEFI_BOOTLOADER variable. For such variable to be set correctly, 310_include_uefi_tools.sh is renamed to 330_include_uefi_tools.sh.

OliverO2 commented at 2017-09-11 14:27:¶

Related: #1477, #1478

OliverO2 commented at 2017-09-11 14:28:¶

Tested on Ubuntu 16.04.3 LTS with UEFI. BIOS-only tests outstanding.

gozora commented at 2017-09-11 14:34:¶

Just for my understanding, this PR supersedes https://github.com/rear/rear/pull/1477, right ?

OliverO2 commented at 2017-09-11 14:38:¶

Yes, it does.

jsmeix commented at 2017-09-12 08:21:¶

@gozora
could you merge it if it is also o.k. for you?

gozora commented at 2017-09-12 09:01:¶

@jsmeix yes, I have no objections here.
@OliverO2 thanks for your contribution!

V.

pcahyna commented at 2017-09-12 09:08:¶

I confirm that it fixes #1478 for me and looks cleaner than anything else.

OliverO2 commented at 2017-09-12 10:33:¶

Thanks everyone!

jsmeix commented at 2017-09-12 12:35:¶

@OliverO2
many thanks for your valuable contribution to ReaR
that did not only fix a particular issue but also cleaned up
overcomplicated code which could help a lot if there are
further issues in this area to get them also properly fixed.

---

[Export of Github issue for rear/rear.]