#1650 PR merged: typo in: if test -n "btrfs_subvolume_path" ; then ?¶

Labels: bug, fixed / solved / done

ProBackup-nl opened issue at 2017-12-17 23:29:¶

The might be a typo in https://github.com/rear/rear/blob/master/usr/share/rear/layout/save/GNU/Linux/230_filesystem_layout.sh#L397

if test -n "btrfs_subvolume_path" ; then
if test -n "$btrfs_subvolume_path" ; then
Or not?

jsmeix commented at 2017-12-18 10:52:¶

@ProBackup-nl
many thanks for finding this bug!
I assume it did not had real bad effects in practice
because on SLE12 systems where that code matters
that special 'chattr' stuff for certain btrfs subvolumes
had always worked for me on my test systems where
I got in var/lib/rear/layout/disklayout.conf

# Mounted btrfs subvolumes that have the 'no copy on write' attribute set.
# Format: btrfsnocopyonwrite 
btrfsnocopyonwrite @/var/lib/libvirt/images
btrfsnocopyonwrite @/var/lib/pgsql
btrfsnocopyonwrite @/var/lib/mariadb
btrfsnocopyonwrite @/var/lib/mysql

jsmeix commented at 2017-12-19 09:51:¶

Verified that it still works on SLES12 with its btrfs default structure.

---

[Export of Github issue for rear/rear.]