#1674 PR merged: Fix/debian packaging

Labels: fixed / solved / done, minor bug

OliverO2 opened issue at 2018-01-03 20:50:

Fixes #1666.

Permissions fixed:

$ ar x *.deb
$ tar tvf data.tar.xz ./etc
drwxr-xr-x root/root         0 2018-01-03 21:30 ./etc/
drwx------ root/root         0 2018-01-03 21:30 ./etc/rear/
drwx------ root/root         0 2018-01-03 21:30 ./etc/rear/cert/
-rw------- root/root       534 2018-01-03 21:01 ./etc/rear/local.conf

Lintian output before:

Now running lintian...
W: rear: syntax-error-in-debian-changelog line 12 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 17 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 22 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 27 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 32 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 40 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 46 "badly formatted trailer line"
W: rear: syntax-error-in-debian-changelog line 73 "found start of entry where expected more change data or trailer"
W: rear: debian-revision-not-well-formed 2.3-git.2727.19052e4.fixdebianpackaging.changed
W: rear: package-contains-timestamped-gzip usr/share/rear/skel/Debian/default.tar.gz
W: rear: manpage-has-errors-from-man usr/share/man/man8/rear.8.gz 526: warning [p 6, 7.3i]: can't break line
W: rear: systemd-service-file-refers-to-obsolete-target usr/share/rear/skel/default/usr/lib/systemd/system/dbus.service syslog.target
W: rear: systemd-service-file-refers-to-obsolete-target usr/share/rear/skel/default/usr/lib/systemd/system/dbus.target.wants/dbus.service syslog.target
Finished running lintian.

Lintian output afterwards:

Now running lintian...
W: rear: debian-revision-not-well-formed 2.3-git.2727.19052e4.fixdebianpackaging.changed
W: rear: manpage-has-errors-from-man usr/share/man/man8/rear.8.gz 581: warning [p 6, 10.0i]: can't break line
W: rear: systemd-service-file-refers-to-obsolete-target usr/share/rear/skel/default/usr/lib/systemd/system/dbus.service syslog.target
W: rear: systemd-service-file-refers-to-obsolete-target usr/share/rear/skel/default/usr/lib/systemd/system/dbus.target.wants/dbus.service syslog.target
N: 3 tags overridden (3 warnings)
Finished running lintian.

Plus:

Documentation generation: Support asciidoctor in addition to asciidoc.

TODO

Figure out whether the syslog.target dependency is still necessary to support older systemd-based distributions. Cf. https://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-target.html

OliverO2 commented at 2018-01-04 13:09:

@gdha As mentioned in 93648932c59dad5e0922efc0712baf5fc0ceff3b;

re-package usr/share/rear/skel/Debian/default.tar.gz w/o timestamp

So I didn't even touch the tar archive. Just ran gunzip default.tar.gz followd by gzip -n default.tar to get rid of the timestamp making Lintian complain.

Cf. gzip(1) option -n:

-n --no-name
When compressing, do not save the original file name and time stamp by default.

gdha commented at 2018-01-04 13:32:

@OliverO2 Thanks for the clarification - sorry I didn't understand it from the first time, but now I do.

OliverO2 commented at 2018-01-04 13:36:

@gdha No problem! Probably my comment should have been more elaborate, particularly since it was addressing a binary file change.


[Export of Github issue for rear/rear.]