#1757 PR merged
: exclude docker FS from layout #1749¶
Labels: enhancement
, fixed / solved / done
, minor bug
gdha opened issue at 2018-03-14 09:24:¶
Pull Request Details:¶
-
Type: Bug Fix
-
Impact: Normal
-
Reference to related issue (URL): https://github.com/rear/rear/issues/1749
-
How was this pull request tested? on AWS docker system
-
Brief description of the changes in this pull request: The file systems used by the docker images should not be saved in the
diskalyout.conf
file
gdha commented at 2018-03-14 17:12:¶
@jsmeix excellent suggestion - why did I not thought of it?
gdha commented at 2018-03-16 09:14:¶
@jsmeix No, not really - you prefer to have it outside the block? I do not expect we need it any further.
jsmeix commented at 2018-03-16 09:34:¶
@gdha
implement it just as you like - it works well at both places.
I myself would move it out of the "writing output to DISKLAYOUT_FILE"
block
because determining docker_is_running
is not "writing output to
DISKLAYOUT_FILE"
but that is a matter of personal taste.
[Export of Github issue for rear/rear.]