#1779 PR merged: skip LUKS encrypted disks when guessing bootloader (issue 1769) and avoid issue 1711¶

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2018-04-19 13:39:¶

• Type: Enhancement

• Impact: Low

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/1769
  and
  https://github.com/rear/rear/issues/1711
  starting at
  https://github.com/rear/rear/issues/1711#issuecomment-380009044

• How was this pull request tested?
  I could only test that RESULT_FILES=($LOGFILE) now works
  but I could not test guessing bootloader with LUKS encrypted disks
  because I do not use LUKS.

• Brief description of the changes in this pull request:
  Skip LUKS encrypted disks when guessing bootloader (issue 1769)
  and
  avoid 'cp' error exit in case of improper RESULT_FILES member (issue 1711)
  as in https://github.com/rear/rear/issues/1711#issuecomment-380018302

jsmeix commented at 2018-04-19 13:45:¶

Furthermore I enhanced the "Hah!IdontNeedEFI" case
cf. https://github.com/rear/rear/issues/1752
and https://github.com/rear/rear/pull/1754
so that now it also detects other non-EFI bootloaders
(in particular also GRUB2).

jsmeix commented at 2018-04-23 07:19:¶

The basic logic of the code for the "Hah!IdontNeedEFI" case is still wrong, see
https://github.com/rear/rear/pull/1754#issuecomment-383478154

I will do a pull request...

---

[Export of Github issue for rear/rear.]