#1785 PR merged: borg ssh port addition

Labels: enhancement, fixed / solved / done

patlegu opened issue at 2018-04-25 09:56:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:

  • Type: Bug Fix / New Feature / Enhancement / Other?
    Enhancement

  • Impact: Low / Normal / High / Critical / Urgent
    Normal

  • Reference to related issue (URL):

  • How was this pull request tested?
    This modification has been tested on a new server with the BORGBACKUP_PORT in /etc/rear/local.conf. The command rear mkbackup has been working and both iso file and borg backup finished without errors. The backup on the borg server can be listed with others, not made with rear.

  • Brief description of the changes in this pull request:
    The change is only to add a new value for having the possibility to change the ssh port used. When you make this change you have to modify the syntax of the borg_dst_dev

patlegu commented at 2018-04-25 10:17:

Here is the detail.

rear -d mkbackup                 
Relax-and-Recover 2.3 / 2017-12-20
Using log file: /var/log/rear/rear-uxdc01.log
Creating disk layout
Using guessed bootloader 'GRUB'
Creating root filesystem layout
Copying logfile /var/log/rear/rear-uxdc01.log into initramfs as '/tmp/rear-uxdc01-partial-2018-04-25T11:01:59+02:00.log'
Copying files and directories
Copying binaries and libraries
Copying kernel modules
Copying all files in /lib*/firmware/
Creating recovery/rescue system initramfs/initrd initrd.cgz with gzip default compression
Created initrd.cgz with gzip default compression (68786156 bytes) in 8 seconds
Making ISO image
Wrote ISO image: /var/lib/rear/output/rear-uxdc01.iso (71M)
Copying resulting files to file location
Saving /var/log/rear/rear-uxdc01.log as rear-uxdc01.log to file location
Synchronizing chunks cache...                                                                                                                                                                                    
Archives: 2, w/ cached Idx: 0, w/ outdated Idx: 0, w/o cached Idx: 2.
Fetching and building archive index for uxdc01_23.04.2018 ...18                                                                                                                                                  
Merging into master chunks index ...
Fetching and building archive index for uxdc01_23.04.2018-1306 ...06                                                                                                                                             
Merging into master chunks index ...
Done.                                                                                                                                                                                                            
------------------------------------------------------------------------------                                                                                                                                   
Archive name: RearUxdc01_1
Archive fingerprint: 9aac3d73ce92aeede16c35e7bcd897eb65a3b21f9230c64703bf8dd83155c79c
Time (start): Wed, 2018-04-25 11:02:21
Time (end):   Wed, 2018-04-25 11:30:46
Duration: 28 minutes 24.55 seconds
Number of files: 67085
Utilization of max. archive size: 0%
------------------------------------------------------------------------------
                       Original size      Compressed size    Deduplicated size
This archive:                1.56 GB            625.34 MB            570.65 MB
All archives:                1.60 GB            654.66 MB            585.39 MB

                       Unique chunks         Total chunks
Chunk index:                   59248                68496
------------------------------------------------------------------------------
You should also rm -Rf /tmp/rear.33TUxyHPXhB1eS3

And the list of borg archive on the remote server.

borg list ::
uxdc01_23.04.2018                    Mon, 2018-04-23 10:57:57 [5c523b2ab8347152b185110d8609de941596753c7a597e5cb2809efc16d6a74b]
uxdc01_23.04.2018-1306               Mon, 2018-04-23 13:06:34 [ae8c6aa849b7e70c76f3e6f2c1b33cbe2c677f94b0648c3b5567be9abe1ee0dd]
RearUxdc01_1                         Wed, 2018-04-25 11:02:21 [9aac3d73ce92aeede16c35e7bcd897eb65a3b21f9230c64703bf8dd83155c79c]

gozora commented at 2018-04-25 15:49:

@patlegu thanks for your corrections!
I'll do couple of tests, especially for USB backend (which should not be affected at all, but you never know ;-) ), and report back once I'm done.

V.

gozora commented at 2018-04-25 17:32:

@patlegu it works good!
One last cosmetic thing to correct, which might be useful for you once your decide to contribute more in the future ;-). As ReaR coding style states, Indentation with 4 blanks (no tabs) should be used. Since you've used only 3 blank spaces, can you please fix this as well?

Thanks!

V.

gozora commented at 2018-04-25 20:53:

@patlegu Thanks for your contribution!
I'll merge it tomorrow if no further objections arise.

V.

gozora commented at 2018-04-26 15:06:

@patlegu
Thanks again for your PR, it is appreciated!

V.

[Export of Github issue for rear/rear.]