#1803 PR merged: Copy backup restore log into recreated system (related to pull request 1797)

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2018-05-08 13:51:

  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL):
    https://github.com/rear/rear/pull/1797

  • How was this pull request tested?
    Works for me with BACKUP=NETFS.
    Not tested BACKUP=TSM but also changed for that
    @schabrolles please have a look regarding TSM
    in particular related to https://github.com/rear/rear/pull/1799

  • Brief description of the changes in this pull request:
    Have backup restore log in the new separated directory $VAR_DIR/restore/
    and copy that directory contents into the recreated system a the end of
    "rear recover" via usr/share/rear/wrapup/default/990_copy_logfile.sh

jsmeix commented at 2018-05-08 13:56:

FYI:
This is not yet finished.
Currently it is my very first steps so that you can see early what I do
and provide early feedback if I do something plain wrong.

jsmeix commented at 2018-05-09 16:38:

Should be better now but still not finished.

@schabrolles
see my current usr/share/rear/restore/NETFS/default/400_restore_backup.sh
where now both stdout and stderr are redirected into the backup restore log file,
see the comments in the code for the reason why.

Perhaps also for usr/share/rear/restore/TSM/default/400_restore_with_tsm.sh
both stdout and stderr should be redirected into the backup restore log file
if you like it this way?

schabrolles commented at 2018-05-10 11:08:

@jsmeix
I agree with https://github.com/rear/rear/pull/1803#issuecomment-387800158. We should also redirect stderr to the log file.

jsmeix commented at 2018-05-17 12:45:

@schabrolles
if you have time for it I would appreciate it if you could test
my latest enhancements regarding TSM backup restore.

jsmeix commented at 2018-05-23 12:03:

@schabrolles @gdha
feel free to postpone this one to ReaR 2.5
or "just merge" it into ReaR 2.4 if you like it as is.

I think currently not all relevant places are fixed but
I think the current state may be already sufficient
for 'tar' and TSM backup.

gdha commented at 2018-05-28 08:50:

@schabrolles You may decide to merge the PR for 2.4 or not.

schabrolles commented at 2018-05-28 09:01:

@gdha,
I will start a test tonight and come back to you tomorrow.

gdha commented at 2018-05-29 07:46:

@schabrolles Thank you for your intensive testing!

[Export of Github issue for rear/rear.]