#1865 PR merged: Added choice to confirm identical layout mapping only once plus disabling MIGRATION_MODE

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2018-07-16 15:17:

Pull Request Details:

Furthermore I added a output_not_recreated_devices function that shows
the currently unmapped disks and dependant devices that will not be recreated
to the user so that the user knows in advance what will not be recreated
with the current mapping so that he can change the mapping as he needs
and in this case things look like:

Current disk mapping table (source => target):
  /dev/sdb => /dev/sdb
Currently unmapped disks and dependant devices will not be recreated
(unless identical disk mapping and proceeding without manual configuration):
  /dev/sda /dev/sda1 /dev/sda2 /dev/sda3 /dev/md0 /dev/md1 /dev/md2 swap:/dev/md0 fs:/ fs:/home
UserInput -I LAYOUT_MIGRATION_CONFIRM_MAPPINGS needed in /usr/share/rear/layout/prepare/default/300_map_disks.sh line 275
Confirm or edit the disk mapping
1) Confirm disk mapping and continue 'rear recover'
2) Confirm identical disk mapping and proceed without manual configuration
3) Edit disk mapping (/var/lib/rear/layout/disk_mappings)
4) Use Relax-and-Recover shell and return back to here
5) Abort 'rear recover'
(default '1' timeout 300 seconds)

What is currently not yet cleaned up is the inconsistency in the ReaR code
how currently is tested whether or not migration mode is active, cf.
https://github.com/rear/rear/issues/1857#issue-340210404

jsmeix commented at 2018-07-17 07:26:

@rear/contributors
because this pull request implements an additional choice
I think it cannot cause regressions for existing functionality
so that I would like to merge it soon today unless you object now.
Of course if issues with the current implementation appear I will fix them.

jsmeix commented at 2018-07-17 07:28:

The cleanup of the current inconsistency in the ReaR code
how currently is tested whether or not migration mode is active
will be done later by a separated pull request as time permits.

[Export of Github issue for rear/rear.]