#1887 PR merged: #1886 - LPAR/PPC64 bootlist is incorrectly set when having multiple 'prep' partitions

Labels: enhancement, bug, cleanup, fixed / solved / done

rmetrich opened issue at 2018-08-01 09:09:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/issues/1886

  • How was this pull request tested?

    Tested on AIX/LPAR/PPC64le with 2 prep partitions, but no multipath on older ReaR 2.00 version

  • Brief description of the changes in this pull request:

    • Added handling of multiple prep partitions
    • Enhanced handling of multiple prep partitions and multipath

jsmeix commented at 2018-08-06 10:14:

@schabrolles
could you have a look here an review it?
If you don't have time I would "just merge" it tomorrow
because it was tested by @rmetrich

jsmeix commented at 2018-08-08 09:17:

@schabrolles
I would like to "just merge" it today afternoon if you do not object, cf.
https://github.com/rear/rear/pull/1887#issuecomment-410659457

schabrolles commented at 2018-08-08 09:52:

@jsmeix, bootlist is responsible to set the boot devices order list for an LPAR in PowerVM.
Unfortunately, My PowerVM system is used for a customer test until end of August. So I'm not able to perform a test to validate it.

jsmeix commented at 2018-08-08 10:20:

@schabrolles
does this pull request look o.k. to you from plain looking at the code
or do you perhaps immediately see something that could be wrong?
If things look o.k. to you, you could approve the pull request with
an appropriate approval comment that you only looked at the code.

schabrolles commented at 2018-08-08 10:33:

@jsmeix, for a plain looking code, this looks correct to me...

jsmeix commented at 2018-08-08 14:10:

@rmetrich
many thanks for your fix and enhancements!

@schabrolles
many thanks for your review!

[Export of Github issue for rear/rear.]