#1951 PR closed: Obey TSM_RESTORE_PIT_... variables in environment (issue 1948)¶

Labels: enhancement, not ReaR / invalid

jsmeix opened issue at 2018-11-05 13:19:¶

• Type: Enhancement

• Impact: Normal

• Reference to related issue (URL):
  https://github.com/rear/rear/issues/1948

• How was this pull request tested?
  Not at all tested by me because I do not use TSM

• Brief description of the changes in this pull request:
  A blind attempt by plain looking at the code
  which is intended as a proposal how I think
  https://github.com/rear/rear/issues/1948
  might be implemented.

jsmeix commented at 2018-11-05 13:33:¶

@schabrolles
I noticed inconsistencies about the date format
for TSM Point-In-Time Restore in what was written in the comments
in default.conf

internally MM/DD/YYYY is used

and in verify/TSM/default/390_request_point_in_time_restore_parameters.sh

LogPrint "Restoring all filespaces from backup before ... (MM/DD/YYYY HH:mm:ss)"

versus what the code
in verify/TSM/default/390_request_point_in_time_restore_parameters.sh
actually does

TSM_RESTORE_PIT_DATE=$( date -d "$REPLY" +%Y.%m.%d 2>/dev/null ) ...

Furthermore is seems the dsmc option -date=5 is set twice first in

TSM_DSMC_RESTORE_OPTIONS=( "${TSM_DSMC_RESTORE_OPTIONS[@]}" -date=5 -pitd="$TSM_RESTORE_PIT_DATE" )

and then again in

TSM_DSMC_RESTORE_OPTIONS=( "${TSM_DSMC_RESTORE_OPTIONS[@]}" -date=5 -pitt="$TSM_RESTORE_PIT_TIME" )

Perhaps it is really needed two times or perhaps it does not matter?

jsmeix commented at 2018-11-05 13:43:¶

Ok ok I better leave here.

FWIW:
I think the usual way are pull requests (at least all others seem to do it this way)?

schlomo commented at 2018-11-05 13:50:¶

Yes, PR is great. That's why I put my code into an issue branch here in our common repo so that everybody in our team can work on it or suggest changes. I was just surprised why you made a PR to master and not to the issue repo.

jsmeix commented at 2018-11-05 14:49:¶

I had missed this comment
https://github.com/rear/rear/issues/1948#ref-commit-f5558ef

---

[Export of Github issue for rear/rear.]