#2037 PR merged: Restoring from Borg backup will now do test list of repository

Labels: enhancement, cleanup, fixed / solved / done

gozora opened issue at 2019-02-10 19:03:

Pull Request Details:

  • Type: Enhancement

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/issues/2029

  • How was this pull request tested?
    Full backup/restore on Fedora (NETFS and USB)

  • Brief description of the changes in this pull request:

  • added checks whether we can read Borg archive, before any changes are written to disk

  • user can enable progress display (BORGBACKUP_SHOW_PROGRESS="yes") for borg extract
  • corrected mounting of USB device when using Borg back end

gozora commented at 2019-02-10 19:04:

@jsmeix if you have a bit of spare time, please check whether you can spot something obviously wrong ...

Thanks!

V.

jsmeix commented at 2019-02-12 09:16:

@gozora
I was not in the office last Thusrday and Friday,
I have a look now...

gozora commented at 2019-02-12 09:27:

@jsmeix

I was not in the office last Thusrday and Friday,
I have a look now...

Thank you kind sir!

V.

jsmeix commented at 2019-02-12 09:46:

I did not spot something obviously wrong => Approved.

gozora commented at 2019-02-12 09:57:

@jsmeix

It is better described in BORG/default/250_mount_usb.sh

# We need to mount USB_DEVICE in order to prepare for Borg archive
# initialization, but only if BORGBACKUP_HOST is not set.
# When BORGBACKUP_HOST is set, we don't need to mount anything as SSH
# backup destination will be handled internally by Borg it self.

so your guess

I guess whether or not BORGBACKUP_HOST is empty is used
to distinguish in the code between Borg => SSH versus Borg => USB
as described in
https://github.com/rear/rear/blob/master/doc/user-guide/04-scenarios.adoc
but I am not a Borg user so that I may ask strange questions about Borg.

is right!

V.

gozora commented at 2019-02-13 18:47:

Hello @jsmeix,

Your suggestions were applied by commit https://github.com/rear/rear/pull/2037/commits/085d4dc37d8ba3babda91cd6a0e1929bd0c7c834.

As always, many thanks for your inputs!

V.

[Export of Github issue for rear/rear.]