#2048 PR closed: Do not patch $TARGET_FS_ROOT/etc/mtab if symbolic link.

Labels: bug, cleanup, fixed / solved / done, won't fix / can't fix / obsolete

gozora opened issue at 2019-02-18 20:27:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/pull/2047#issuecomment-464846777

  • How was this pull request tested?
    Full backup restore on Arch Linux with:

  • mtab as regular file

  • mtab as symbolic link

  • Brief description of the changes in this pull request:
    In the past when /etc/mtab was a regular file it was desirable to update disk UUIDs inside file (along with /etc/fstab)
    When /etc/mtab become symbolic link pointing to /proc/mtab resp /proc/self/mtab, we don't want to perform any replacements with sed -i (nor any other editor) because data are already up to date.

jsmeix commented at 2019-02-19 10:52:

@gozora
I think this is obsoleted by my attempts to improve
usr/share/rear/finalize/GNU/Linux/280_migrate_uuid_tags.sh via
https://github.com/rear/rear/pull/2047/commits/6b1889cbf7bed297a5a695fd01f52865c4527827
but I need to test it...

gozora commented at 2019-02-19 11:47:

@jsmeix yes totally OK for me!

Closing (without merging) in favor of https://github.com/rear/rear/pull/2047

V.

[Export of Github issue for rear/rear.]