#2065 PR merged: network: Record permanent mac address when device is enslaved in a Team, or else /etc/mac-addresses will record broken information

Labels: enhancement, fixed / solved / done

rmetrich opened issue at 2019-03-04 11:08:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): See PR https://github.com/rear/rear/pull/1954

  • How was this pull request tested? Tested on RHEL7 with a Team on eth0 and eth1

  • Brief description of the changes in this pull request:

Use "ethtool -P" as the preferred method to retrieve the MAC address.
Otherwise fall back to other methods, which may lead to some invalid MAC address when using Teams.

rmetrich commented at 2019-03-05 11:34:

@pcahyna Can you test on your system (I did of course, but just want to be sure)

pcahyna commented at 2019-03-05 11:48:

@rmetrich I will and report the result. Thanks!

pcahyna commented at 2019-03-06 23:40:

I tested your patch with and without LACP (teaming only) and it indeed fixed the issue for both cases. I haven't checked bonding for regressions yet.


[Export of Github issue for rear/rear.]