#2096 PR merged: fixed bootlist (special thanks to pcahyna++)¶

Labels: bug, fixed / solved / done

rmetrich opened issue at 2019-03-22 09:10:¶

Correction to #1886 - LPAR/PPC64 bootlist is incorrectly set when having multiple 'prep' partitions

jsmeix commented at 2019-03-22 09:29:¶

@rmetrich
a question:
Is there a reason why in that code ${boot_list[@]} without double quotes is used?

Because in general using ${VAR[@]} without double-quotes is problematic,
see 'Arrays' in "man bash" and for some examples see
https://github.com/rear/rear/issues/1068

rmetrich commented at 2019-03-22 09:41:¶

No special reason. Here devices are used so there is no space, so no issue.

jsmeix commented at 2019-03-22 11:51:¶

... no issue except https://github.com/rear/rear/pull/2097
;-)

Thanks for having a closer look and have a nice weekend!

pcahyna commented at 2019-03-23 08:27:¶

@jsmeix indeed, it is better to avoid possibly problematic constructs, even if they seem ok, because:

• someone might copy the code to a place where it does matter
• the original bug was found by shellcheck, which flags such problematic constructs, and the less false positives in shellcheck reports I have to examine, the higher are the chances that I will spot true problems.

---

[Export of Github issue for rear/rear.]