#2115 PR merged
: Simplify awk constructs in 320_include_uefi_env.sh (issue #2095)¶
Labels: bug
, cleanup
, fixed / solved / done
jsmeix opened issue at 2019-04-11 11:07:¶
-
Type: Bug Fix
-
Impact: Normal
-
Reference to related issue (URL):
https://github.com/rear/rear/issues/2095 -
How was this pull request tested?
Seems to work well for me on openSUSE Leap 15.0
# usr/sbin/rear -D mkrescue
...
Found EFI system partition /dev/sda1 on /boot/efi type vfat
Using UEFI Boot Loader for Linux (USING_UEFI_BOOTLOADER=1)
- Brief description of the changes in this pull request:
The - from my point of view - needlessly overcomplicated
local variables (sometimes uppercased) and their awk
constructs
are simplified into using plain grep
and a bash array
to avoid inexplicable wrong behaviour in some cases
that is somehow related to the nullglob
bash option, cf.
https://github.com/rear/rear/issues/2095#issuecomment-481833946
together with different kind of awk
, cf.
https://github.com/rear/rear/issues/2095#issuecomment-481838163
Additionally there is better user info in debug mode via DebugPrint
(in particular when things do not work as usually expected).
[Export of Github issue for rear/rear.]