#2119 PR merged: btrfs subvolumes generic: fix 'subvolume set-default' for older versions

Labels: fixed / solved / done, minor bug

OliverO2 opened issue at 2019-04-16 10:44:

Pull Request Details:

OliverO2 commented at 2019-04-16 10:49:

@jsmeix Hopefully, this fix makes the generic code work on SLES12 now - and on the entire universe ;-).

jsmeix commented at 2019-04-26 08:54:

Not urgent or "must have" for ReaR 2.5 so postponed to ReaR 2.6

OliverO2 commented at 2019-05-01 13:53:

I'd like you to reconsider including this PR into ReaR 2.5, too, for these reasons:

  1. The entire script 135_include_btrfs_subvolumes_generic_code.sh is not enabled by default, but depends on the yet undocumented variable BTRFS_SUBVOLUME_GENERIC_SETUP.
  2. It is a tiny change, which has been successfully tested in several mkrescue/recover cycles while checking that a default subvolume (and thus the changed code) was actually used.
  3. If people want to try the new code in its packaged form, they should have a positive experience on first use, even on older OS versions.

Of course, after releasing ReaR 2.5, the entire code should still be tested on a wider range of systems (including the ancient ones). The design goal remains to have just one copy of btrfs subvolume handling code.

jsmeix commented at 2019-05-02 08:41:

@OliverO2
of course I agree with your
https://github.com/rear/rear/pull/2119#issuecomment-488288078

I only liked to test it also on SLES out of curiosity
but found no time yet...

Because SLES uses totally separated different code
this changes cannot cause regressions on SLES
so that I can "blindly approve" them for SLES.

@gdha
should we have that in ReaR 2.5?
From my current selfish SLES-only point of view I would say yes.

gdha commented at 2019-05-02 10:51:

@jsmeix release 2.5 is fine for me.

OliverO2 commented at 2019-05-02 11:00:

Thanks to both of you!

@jsmeix https://github.com/rear/rear/pull/2119#issuecomment-488593331

I only liked to test it also on SLES out of curiosity
but found no time yet...

Sure, and I also understand that you'd like to get the release done. Would you like me to add an issue for the integration testing so that there some reminder after this PR is merged?

[Export of Github issue for rear/rear.]