#2126 PR merged: Fix layout mapping

Labels: bug, fixed / solved / done

OliverO2 opened issue at 2019-04-28 16:38:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): none

  • How was this pull request tested? Ran rear mkrescue and rear recover on Ubuntu 18.04.2 LTS server before and after patching. Verified fix works as intended.

  • Brief description of the changes in this pull request:

This PR corrects a mapping error when TCG Opal 2 self-encrypting disks were present but had to be excluded due to a non-existent disk during recovery. This exclusion was not handled properly.

(Edit: dropped second change)

jsmeix commented at 2019-04-29 09:22:

@OliverO2
I assume this issue hapens only when you are in MIGRATION_MODE
because the apply_layout_mappings function is only called there.

I would like to better understand what actually goes on on your
particular system because 'an unmapped disk was present' looks like
things are wrong because - as far as I can imagine offhandedly - there
must not be any unmapped disk left, see my comments in the
apply_layout_mappings function that show an example where
the _REAR*_ string disk _REAR3_ is left which is then
correctly detected and reported by "Step 3".

jsmeix commented at 2019-04-30 07:38:

@gdha
could you also have a look here and review it?

Do you think we can add it to ReaR 2.5?

gdha commented at 2019-04-30 09:06:

@jsmeix I'm fine for release 2.5,
@OliverO2 Thank you for improving rear code base.

jsmeix commented at 2019-04-30 10:25:

Merged and listed in the ReaR 2.5 release notes via
https://github.com/rear/rear.github.com/commit/a78033bf1b97e0b3f638cf32c5f11ce5e049c085

[Export of Github issue for rear/rear.]