#2147 PR merged: Improvements and fixes for 950_copy_result_files (related to issue2137)

Labels: bug, fixed / solved / done

jsmeix opened issue at 2019-05-23 07:31:

Before output/default/950_copy_result_files.sh falsely errors out with

Could not copy '/usr/share/rear/conf/templates/RESULT_usage_FOO.txt'

cf. https://github.com/rear/rear/pull/2142#issuecomment-495010023
when OUTPUT=FOO is used where no
usr/share/rear/conf/templates/RESULT_usage_FOO.txt
exists.
Currently only
usr/share/rear/conf/templates/RESULT_usage_PXE.txt
usr/share/rear/conf/templates/RESULT_usage_RAMDISK.txt
usr/share/rear/conf/templates/RESULT_usage_ISO.txt
usr/share/rear/conf/templates/RESULT_usage_RAWDISK.txt
usr/share/rear/conf/templates/RESULT_usage_USB.txt
exists so that 950_copy_result_files.sh falsely errors out for all
other OUTPUT methods.

Additionally 950_copy_result_files.sh is now skipped
if RESULT_FILES is empty at the beginning of the script
because I think if there are no actual RESULT_FILES
it means there is no actual output and then is is useless
to copy VERSION and README and LOGFILE
to the output location.
I think it could be questionable if perhaps LOGFILE
should be always copied to the output location
even if there is no actual output.
If LOGFILE should be always copied to the output location
I can easily fix that.

jsmeix commented at 2019-05-23 07:39:

Because this is needed by @mutable-dan
to proceed with his https://github.com/rear/rear/pull/2142
cf. https://github.com/rear/rear/pull/2142
I merge it right now.

If there are issues with this changes here
I will of course fix them.

[Export of Github issue for rear/rear.]