#2154 PR merged: Fix for issue 2151: only the first 2 parameters in /etc/crypttab are …

Labels: enhancement, bug, fixed / solved / done

petroniusniger opened issue at 2019-06-04 12:51:

…mandatory on openSUSE.

Pull Request Details:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): https://github.com/rear/rear/issues/2151

  • How was this pull request tested?

    • aligned working copy on trunk/LATEST
    • added encrypted LV inside VM (using simple password for key)
    • created recovery image and backup from test VM
    • stopped VM, deleted and recreated virtual HDD
    • recovered VM from ReaR image + backup
    • new LV was recreated as encrypted, a new password was asked for interactively during recovery phase

  • Brief description of the changes in this pull request:

The awk script on line 43 of layout/save/GNU/Linux/260_crypt_layout.sh was modified to also allow for an empty third parameter in /etc/crypttab (in addition to the existing values of 'none' and '-').

This difference in the /etc/crypttab format is documented in its openSUSE man page, quoted here: https://github.com/rear/rear/issues/2151#issuecomment-496575055 (Leap 15.0 version).

jsmeix commented at 2019-06-05 07:35:

@rear/contributors
could someone have a look here and merge it if it is o.k.
because I know nothing about LUKS

gdha commented at 2019-06-05 08:33:

PR approved and merged

[Export of Github issue for rear/rear.]