#2184 Issue closed: USE_DHCLIENT="yes" does not add a (non-empty) dhclient program to REQUIRED_PROGS

Labels: bug, fixed / solved / done

jsmeix opened issue at 2019-07-15 14:01:

Current ReaR master code.

Using USE_DHCLIENT="yes" in etc/rear/local.conf
does not enforce to have any dhclient program
in the ReaR recovery system so that without a dhclient program
on the original system rear mkrescue "just works" but results a
partially useless ReaR recovery system where DHCP does not work.

jsmeix commented at 2019-07-15 14:01:

I will fix and enhance prep/GNU/Linux/210_include_dhclient.sh accordingly.

The bug is when there is no dhclient program installed it results
this /tmp/rear.XXX/rootfs/etc/rear/rescue.conf lines

USE_DHCLIENT=yes
DHCLIENT_BIN=
DHCLIENT6_BIN=

while when there is a dhclient program installed it results
/tmp/rear.XXX/rootfs/etc/rear/rescue.conf lines like

USE_DHCLIENT=yes
DHCLIENT_BIN=dhclient
DHCLIENT6_BIN=dhclient6

so an additional test in prep/GNU/Linux/210_include_dhclient.sh
to Error out when DHCLIENT_BIN and DHCLIENT6_BIN are empty
and USE_DHCLIENT is set should be all what is needed here.

jsmeix commented at 2019-07-16 14:35:

With https://github.com/rear/rear/pull/2185 merged
this issue should be fixed.


[Export of Github issue for rear/rear.]