#2189 PR merged
: In apply_layout_mappings it is no error when there are leftover replacement strings in comments¶
Labels: enhancement
, fixed / solved / done
jsmeix opened issue at 2019-07-18 12:44:¶
-
Type: Enhancement
-
Impact: Low
-
Reference to related issue (URL):
https://github.com/rear/rear/issues/2183 -
How was this pull request tested?
By me, see
https://github.com/rear/rear/issues/2183#issuecomment-512791873 -
Brief description of the changes in this pull request:
In the function apply_layout_mappings (therein in its "step 3")
only treat leftover temporary replacement words as an error
if they are in a non-comment line (comments have '#' as first non-space
character),
see
https://github.com/rear/rear/issues/2183#issuecomment-511394129
Additionally I added in 420_autoresize_last_partitions.sh
the missing word 'bytes' to DebugPrint messages
so that the output changes e.g. from
New /dev/vda is 21474836480 smaller than old disk
to
New /dev/vda is 21474836480 bytes smaller than old disk
jsmeix commented at 2019-07-18 12:45:¶
Because it "just works" for me I would like to merge it soon today
unless there are objections right now.
[Export of Github issue for rear/rear.]