#2196 PR merged: Minor adjustments to #2194

Labels: enhancement, fixed / solved / done

pcahyna opened issue at 2019-07-29 16:15:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:

  • Type: Cleanup

  • Impact: Low

  • Reference to related issue (URL): #2187

  • How was this pull request tested?
    Comparing disklayout generated before and after. Here is the difference:

 # Format for LVM LVs
 # lvmvol <volume_group> <name> <size(bytes)> <layout> [key:value ...]
 # WARNING: Volume rhel_ibm-p9wr-08/home has multiple segments. Restoring it in Migration Mode using 'lvcreate' won't preserve segments and properties of the other segments as well!
-lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear segmentsize:2000393601024b
-#lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear segmentsize:1941333606400b
+lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear 
+# extra parameters for the line above not taken into account when restoring using 'lvcreate': segmentsize:2000393601024b
+#lvmvol /dev/rhel_ibm-p9wr-08 home 3941727207424b linear 
+# extra parameters for the line above not taken into account when restoring using 'lvcreate': segmentsize:1941333606400b
  • Brief description of the changes in this pull request:
    Minor adjustments to #2194. Do not overload the kval variable - intended for passing options to lvcreate - by adding extra keys to it, which are not supported by lvcreate. Introduce another variable infokval for this purpose and print those unsupported and purely informational keys only in comments.

[Export of Github issue for rear/rear.]