#2224 PR merged: Fix for #2222 - Thin pool recreation logic / use of vgcfgrestore is broken

Labels: bug, fixed / solved / done

rmetrich opened issue at 2019-09-04 11:05:

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:

  • Type: Bug Fix

  • Impact: Normal

  • Reference to related issue (URL): #2222

  • How was this pull request tested?

Restored on RHEL8 and RHEL7:

  • overwriting original disk layout (use case: same system)
  • overwriting different disk layout (use case: reuse of a disk)
  • pushing disk layout from non formatted disk (use case: new disk or cloning of system)
  • Brief description of the changes in this pull request:

Removing forcibly (with '--force' passed twice) just works. Additionally, activation of the VG was missing in the original code for #1806

rmetrich commented at 2019-09-05 12:47:

@pcahyna Any concern?

pcahyna commented at 2019-09-05 13:16:

I disagree. One should not just increase the amount of --force to attempt to solve the problem. One should not use vgcfgrestore if the VG contains anything else than linear or striped volumes (and then try to fix the inconsistent configuration by removing other volumes) in the first place.

rmetrich commented at 2019-09-05 13:18:

Using vgcfgrestore then removing thin pools is always better than using vgcreate/lvcreate commands from the beginning, because we don't have the code yet to reproduce what was created initially.

gdha commented at 2019-09-11 08:39:

@schabrolles Any thoughts from your side?

gdha commented at 2019-09-13 06:32:

@rmetrich I guess you can merge the PR if no-one disapproves...

rmetrich commented at 2019-09-13 06:45:

@pcahyna For now I prefer to merge this which is a quick fix to the issue. In the future, I will try enhancing the gathering of LVM informations to stop relying on vgcfgrestore which is a mis-use of the tool.

jsmeix commented at 2019-09-17 11:11:

@rmetrich @pcahyna
thank you for all your time and contributions
to fix and improve the LVM support in ReaR!

[Export of Github issue for rear/rear.]