#2239 Issue `closed`: Enhanced default for AUTOEXCLUDE_PATH¶

Labels: enhancement, fixed / solved / done

jsmeix opened issue at 2019-09-13 14:31:¶

Currently we have in default.conf

# Automatically exclude filesystems mounted under directories given here
# The default is /media to exclude USB devices mounted there.
# This is different from EXCLUDE_MOUNTPOINTS, which accepts only mountpoints.
AUTOEXCLUDE_PATH=( /media )

The recent issues like
https://github.com/rear/rear/issues/2215#issuecomment-521815673
(excerpt)

EXCLUDE_RECREATE=( "${EXCLUDE_RECREATE[@]}" "fs:/run/media" )

The problem is that it seems to exclude only exact paths
(eg. fs:/run/media/[USER]/[DISK_LABEL]),
and not everything inside /run/media.
It also does not expand globs like fs:/run/media/*.

and
https://github.com/rear/rear/issues/2229#issuecomment-531075116
(excerpt)

Changing to
AUTOEXCLUDE_PATH=( /run/media /mnt )
avoids commenting out components I want,
and also automatically excludes any temporary USB devices.

indicate that a nowadays better default for AUTOEXCLUDE_PATH
could be something like

AUTOEXCLUDE_PATH=( /media /run/media /mnt )

jsmeix commented at 2019-10-01 15:49:¶

@rear/contributors
what do you think about a nowadays better default for
AUTOEXCLUDE_PATH to be something like

AUTOEXCLUDE_PATH=( /media /run/media /mnt )

?

gdha commented at 2019-10-02 07:18:¶

@jsmeix

what do you think about a nowadays better default for
AUTOEXCLUDE_PATH to be something like
AUTOEXCLUDE_PATH=( /media /run/media /mnt )

Sure why not.

rmetrich commented at 2019-10-02 08:04:¶

I would even propose

AUTOEXCLUDE_PATH=( /media /run /mnt /tmp )

jsmeix commented at 2019-10-02 11:38:¶

@rear/contributors
please review and test https://github.com/rear/rear/pull/2244
because I fear the impact could be high for some users
(e.g. when someone has /tmp mounted and expects that to be included).

jsmeix commented at 2019-10-05 13:01:¶

@rmetrich
regarding /tmp in AUTOEXCLUDE_PATH
I wonder if recovery still works o.k. by default
when one has /tmp mounted as a separated normal
filesystem like a separated disk with only /dev/sdc1
that is ext2 mounted at /tmp

jsmeix commented at 2019-10-24 12:57:¶

In https://github.com/rear/rear/pull/2261#issue-332030061
I tested that it still works with a separated filesystem on /tmp.

With https://github.com/rear/rear/pull/2261 merged
I hope this issue is sufficiently done.

[Export of Github issue for rear/rear.]

#2239 Issue closed: Enhanced default for AUTOEXCLUDE_PATH¶